Cmake - pkgconfig and installation files #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 22, 2017 19:46
…llation of the required headers files.
| @@ -10,6 +10,9 @@ set(BUILD_TYPE Release) | |||
|
|
|||
| set(EXECUTABLE_OUTPUT_PATH bin) | |||
| set(LIBRARY_OUTPUT_PATH lib) | |||
| set(INCLUDE_OUTPUT_PATH include/dso) | |||
| set(CMAKE_OUTPUT_PATH ${LIBRARY_OUTPUT_PATH}/cmake/dso) | |||
There was a problem hiding this comment.
CMAKE_OUTPUT_PATH seems unused. Did you have plans to include a DSOConfig.cmake DSOConfigVersion.cmake as well?
There was a problem hiding this comment.
In principle I don't plan to create those files right now but it can be done in a following step.
Are you suggesting to remove CMAKE_OUTPUT_PATH in order to merge this PR?
There was a problem hiding this comment.
I was mostly just wondering why it is there, if it is unused.
There was a problem hiding this comment.
Ah! Good question. I think is because I had in mind to create a FindDSO.cmake file (sorry it was some time ago).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
cmake .. -DDSO_BUILD_STATIC_LIBRARY=OFF