Replace ruamel.yaml with PyYAML and Cleanup Imports (Sourcery refactored)
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This commit makes several improvements with the goal of enhancing code maintainability. Several import statements have been reorganized for consistency and improved readability. ruamel.yaml package usage has been replaced with yaml PyYAML parsing. This decision was made due to its wider usage, more frequent updates, and better integration. This change also necessitates updates in requirement.txt and setup.py. Unit and UAT tests have been updated to reflect these changes. Mkdoxy version has been bumped from 1.1.5 to 1.1.6 to indicate these changes.
The library 'ruamel.yaml' was removed from the development dependencies in setup.py. This was done because it's no longer necessary for the current version of the application. The application's functionality should remain unaffected.
sourcery-ai
bot
force-pushed
the
sourcery/pull-73
branch
from
ffa6fe1
to
b010fc4
Compare
tests-old/metaDataParse.py
Outdated
Comment on lines
59
to
60
| yaml = YAML(typ='safe') | ||
| config = yaml.load(meta) | ||
| yaml.dump(config, sys.stdout) No newline at end of file | ||
| meta = match["meta"] |
There was a problem hiding this comment.
Lines 60-60 refactored with the following changes:
- Replace m.group(x) with m[x] for re.Match objects (
use-getitem-for-re-match-groups)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #73 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!