This repository has been archived by the owner on Feb 14, 2021. It is now read-only.
Tooltips for components shown in the mock #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubKoralewski
approved these changes
Feb 3, 2021
There was a problem hiding this comment.
generally it's great 🎉 awesome
idk how pedantic we should be about it working perfectly, I feel like its great as it is, but couple ideas:
- the show can also be visible from the
AddShowscomponent where theSELECTbutton is not shown, so the tooltip kinda doesnt make sense - the notification (tooltip) doesnt show up cause you added the tooltip on mobile
i approve
| className={className} | ||
| style={{ display: `inline-block` }} | ||
| <StyledTooltip | ||
| title={TooltipStrings.showListItemSelect} |
Comment on lines
+198
to
+207
|
|
||
| <IconButton aria-label="show 11 new notifications" color="inherit"> | ||
| <Badge badgeContent={11} color="secondary"> | ||
| <NotificationsIcon /> | ||
| </Badge> | ||
| <StyledTooltip | ||
| title={TooltipStrings.notificationsButton}> | ||
| <Badge badgeContent={11} color="secondary"> | ||
| <NotificationsIcon /> | ||
| </Badge> | ||
| </StyledTooltip> | ||
| </IconButton> | ||
|
|
There was a problem hiding this comment.
it works well it's just that you put the tooltip inside renderMobileMenu which is specific jsut to mobile:
|
Looks and works great! |
|
gj @AdrianKlessa, works for me now on desktop u can merge if ure finished with changes to this branch |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltips as a component, 'batteries included'. Werks and looks decent, and does not pollute existing code.
@JakubKoralewski, please check the tooltip for Notifications, as despite adding it to the Header, it seems that I cannot get the right ancestor of the
<NotificationsIcon />.