This repository has been archived by the owner on Feb 14, 2021. It is now read-only.
add ability to login with credentials #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `initiateDb.ts` file should probably be split into small enough chunks that we can safely import stuff without having to do these shananigans
I got the `papertrail:choklad` string from this link https://blog.heroku.com/introducing_the_app_json_application_manifest
This happens right after loggin in `/app` and it seems to be a client only problem and I have no idea what is causing it I really should have run `npm run build` etc. so I'll try that if this fails. Sorry future me
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the ability to login with credentials "guest1", and "guest2" in testing (when the environment variable
NODE_ENVis set todevelopment) and in Heroku Review Apps. This should make it easier to test (both actually write tests with authorization as well as simply preview what the change does before merging it in), and actually allows to login in the Review Apps, as previously when GitHub was the only option it was impossible (more info on why here)