Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split down 2 pdf viewers buggy #849

Closed
Astrantia opened this issue Oct 5, 2018 · 8 comments
Closed

Split down 2 pdf viewers buggy #849

Astrantia opened this issue Oct 5, 2018 · 8 comments

Comments

@Astrantia
Copy link
Contributor

Astrantia commented Oct 5, 2018

Not sure if this is a bug within the vscode api, but trying to get a split down view for 2 different pdf viewers is impossible now or at least very buggy. When you split open a new pdf, the old pdf disappears. Is this related to how pdfs are served? Are they served on one port?

demo here: https://i.imgur.com/xcKUDvq.gifv

@Astrantia Astrantia changed the title Split down 2 pdf viewers Split down 2 pdf viewers buggy Oct 5, 2018
@James-Yu
Copy link
Owner

James-Yu commented Oct 5, 2018

Released a new fix in 5.11.1.

@Astrantia
Copy link
Contributor Author

Astrantia commented Oct 5, 2018

@James-Yu doesn't work unfortunately :(

I cant seem to split open horizontally. Each time I try to split it horizontally, it is split vertically instead.

@James-Yu
Copy link
Owner

James-Yu commented Oct 5, 2018

It works just correct on my side. If not working, please provide details.

image

@Astrantia
Copy link
Contributor Author

Astrantia commented Oct 5, 2018

@James-Yu
https://i.imgur.com/oZw4jjB.gifv
Exceptions in dev tools:

[Embedded Page] Uncaught (in promise) SecurityError: Failed to read the 'localStorage' property from 'Window': Access is denied for this document. webviewElement.ts:124 
[Embedded Page] Uncaught (in promise) SecurityError: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.

@James-Yu
Copy link
Owner

James-Yu commented Oct 5, 2018

But what's wrong with the behavior? A new panel is created and the original one does not disappear. You can drag the same or multiple pdfs in the new panel and both persist.

@Astrantia
Copy link
Contributor Author

Oops, here's the issue: https://i.imgur.com/oZw4jjB.gifv

James-Yu added a commit that referenced this issue Oct 5, 2018
@James-Yu
Copy link
Owner

James-Yu commented Oct 5, 2018

This is the best I can get. Until vscode allowed extensions to hook file types, this might be the best solution.

@Astrantia
Copy link
Contributor Author

@James-Yu Is that in reference to this issue? microsoft/vscode#12176

Repository owner locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants