Expose EventEmitter methods on gpio.promise #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs say:
That's not quite true, because this doesn't work:
This PR fixes that in the simplest way, by just exposing all the interesting event emitter methods from GPIO on the promise object, bound back to GPIO.
These methods don't actually use promises of course, but being able to use
.promise
as a drop-in replacement is super useful imo, and from the docs above it seems like that's what you're aiming for.