Added composer.json. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, accepted. |
|
I believe I have done so now. Let me know if it's not working as expected. |
|
Great @JamesHeinrich :) |
jrfnl
added a commit
to jrfnl/getID3
that referenced
this pull request
Aug 22, 2021
The `getid3_lib::mb_basename()` method calls the PHP native `basename()` function, the second parameter of which is the _optional_ `$suffix` parameter which expects a `string`. A parameter being optional, however, does not automatically make it nullable. As of PHP 8.1, passing `null` to a non-nullable PHP native function will generate a deprecation notice. In this case, this function call yielded a `basename(): Passing null to parameter JamesHeinrich#2 ($suffix) of type string is deprecated` notice. Changing the `null` default value for the `$suffix` parameter to an empty string fixes this for _most_ cases without BC-break. Leaving the deprecation warning in place for when calls to the function would pass `null` for the `$suffix` so they can adjust their function call. Refs: * https://www.php.net/manual/en/function.basename.php * https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
Closed
StudioMaX
added a commit
to StudioMaX/getID3
that referenced
this pull request
Dec 28, 2021
…inrich#2 ($replace) of type array|string is deprecated
avdeijk
added a commit
to avdeijk/getID3
that referenced
this pull request
Dec 13, 2022
…on notices for preg_match(): Passing null to parameter JamesHeinrich#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added composer.json to allow library install and dependency management with Composer.
To achieve this, please register the repo in Packagist.