PHP 8.1: getid3_quicktime::QuicktimeParseContainerAtom(): fix deprecation notice #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion notice The `$atom_structure` is declared at the start of the method as `false`, but is subsequently assigned to as if it were an array in line 2122. This will throw a deprecation notice as of PHP 8.1: `Deprecated: Automatic conversion of false to array is deprecated in path/to/getid3/module.audio-video.quicktime.php on line 2122` Fixed now, by setting the initial value as an empty array, breaking out of the `while` instead of returning and checking whether the array is still empty at the end, and if so, returning `false`. This should maintain the existing behaviour, but get round the deprecation notice. Ref: https://wiki.php.net/rfc/autovivification_false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$atom_structureis declared at the start of the method asfalse, but is subsequently assigned to as if it were an array in line 2122.This will throw a deprecation notice as of PHP 8.1:
Deprecated: Automatic conversion of false to array is deprecated in path/to/getid3/module.audio-video.quicktime.php on line 2122Fixed now, by setting the initial value as an empty array, breaking out of the
whileinstead of returning and checking whether the array is still empty at the end, and if so, returningfalse.This should maintain the existing behaviour, but get round the deprecation notice.
Ref: https://wiki.php.net/rfc/autovivification_false