Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kept running into this issue this weekend with Liza's portfolio site. If you deploy via this action with a custom domain, Github will nuke the configuration for the domain as the
CNAME
file is no longer present in thegh-pages
branch. In order to solve this I've added an additional environment variable calledCNAME
which will add the domain record into the build directory prior to the deploy. This will maintain the GitHub configuration which will solve the issue of pages 404ing after the deploy.Testing Instructions
https://reddit-viewer.jives.dev
.