Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames ACCESS_TOKEN to GITHUB_TOKEN #8

Closed
wants to merge 2 commits into from

Conversation

ivoputzer
Copy link

Description
Renames ACCESS_TOKEN env-variable to GITHUB_TOKEN.

As of right now, Github allows you to use the GITHUB_TOKEN variable directly from within the workflow without any further configuration so to me it makes sense to name the variable accordingly.

https://developer.github.com/actions/managing-workflows/storing-secrets/#github-token-secret

WDYT?

Testing Instructions
I have setup a workflow at https://github.com/ivoputzer/github-page which uses the fork as of right now.

@JamesIves
Copy link
Owner

@ivoputzer Thanks for the PR!

The problem with this is that the GITHUB_TOKEN variable that is provided with Github Actions doesn't have sufficient permissions to trigger a re-deploy of the gh-pages branch. Using this will prevent your new changes from being deployed consistently. The work around for this is to use a Personal Access Token to force Github pages to re-build.

There's a related issue to this here: #5

I don't think anything has changed on Github's end to make this work, but if you're having better luck with it I can give it a try and perhaps send of a few emails to their team.

@JamesIves JamesIves added the researching 📒 Currently researching potential fixes. label Jul 16, 2019
@JamesIves
Copy link
Owner

JamesIves commented Aug 25, 2019

Closing this in favor of #13 - I appreciate the help with this one!

@JamesIves JamesIves closed this Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
researching 📒 Currently researching potential fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants