James.yang/nuts revamp #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,12 +12,20 @@ struct Constant : util::VarExpr<Constant<ValueType>> | |||
| Constant(value_t c) | |||
| : c_{c} | |||
| {} | |||
| value_t get_value(size_t) const { | |||
| value_t get_value(size_t = 0) const { | |||
There was a problem hiding this comment.
Defaulting this scares me a little because it changes the API. Is there any way this could be a problem?
There was a problem hiding this comment.
We're ignoring this param anyway. This allows users to simply call get_value(). I think enforcing developers to pass in a number to get_value even when it's not going to get used is very confusing.
|
|
||
| size_t max_depth = 10; | ||
| size_t seed = 4821; | ||
| nuts(model, warmup, n_samples, n_adapt, seed, |
There was a problem hiding this comment.
I think we need some more end to end tests like this. Take some of the more complicated regression tests and incorporate them here for NUTS.
There was a problem hiding this comment.
I know I was tired yesterday. Updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.