-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove optional dependencies. #17
Comments
Thanks for posting this. I could have overlooked something, but I'm not sure how this can be possible given that only the npm tarballs are stored. Unlikely, but you've not checked in node_modules as well or anything have you? |
No, not checked in. Did some digging, looks like the way the fsevents is specified causes the tarball not to be fetched at all when installing from npm. fsevents is specified as an optional dependency here: and the os is specified here: and according to this issue: http://stackoverflow.com/questions/15176082/npm-package-json-os-specific-dependency this will mean that fsevents will simply not be installed (in at least normal installation via npm) In this case however, the original OS was mac so the tarball was pulled down and cached. Then when moving to linux I guess it will try to extract and install the tarball causing the issue. |
That's really useful, thanks a lot for digging that up. I'll have a think about what can be done about it. |
👍 |
@digitalsadhu could you do me a favour? if you were to follow the same steps but without using |
For anyone who runs into this and doesn't want to wait for the NPM fix here is a workaround :: https://github.com/bocoup/service-catalog/blob/fe3fab7fc67d7b0e595db59e90377b5a8dbe7338/tools/fix-shrinkwrap.js |
Thanks a lot Kurtis, that'll be handy. |
Reopening to apply bocoup's fix as per @kkemple's #17 (comment). |
Sorry for the wait @digitalsadhu @kkemple – a proposed fix is now in develop. |
thanks for this addition! can't wait to remove my custom script everywhere! |
You're welcome, happy to help.
|
(mac only dependency fsevents will be installed)
Have you run into this sort of thing before? Is it even possible to fix such a thing?
The text was updated successfully, but these errors were encountered: