Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve _ShareType.scss (matrix-org#8737)
* Specify the button style explicitly removing the dependency on the mixin The reset mixin can cause style inconsistencies by disrupting cascading arbitrarily, increasing the number of specified declarations more than needed. Though it might be useful for development, it is not necessary to use it, makes it difficult to grasp the style structure, and can be removed to optimize the structure. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Remove element='button' from AccessibleButton Since AccessibleButton has role='button' by default, setting the element button property is redundant. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Protect mx_ShareType_option from being regressed structurally Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * yarn run lint:style --fix Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Wrap buttons with declarations for spacing box-sizing is not required for the buttons or the wrapper. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * yarn run lint:style --fix Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * fix eslint errors Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Fix LocationShareMenu-test.tsx AccessibleButton is div by default Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Reflect the review Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Revert "Remove element='button' from AccessibleButton" This reverts commit af78d27. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Revert "Fix LocationShareMenu-test.tsx" This reverts commit 7d783a7. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
- Loading branch information