This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Improve _ShareType.scss #8737
Merged
Improve _ShareType.scss #8737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reset mixin can cause style inconsistencies by disrupting cascading arbitrarily, increasing the number of specified declarations more than needed. Though it might be useful for development, it is not necessary to use it, makes it difficult to grasp the style structure, and can be removed to optimize the structure. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Since AccessibleButton has role='button' by default, setting the element button property is redundant. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
box-sizing is not required for the buttons or the wrapper. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
bot
added
the
T-Task
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
AccessibleButton is div by default Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
weeman1337
suggested changes
Jun 2, 2022
There was a problem hiding this comment.
Thanks for your contribution @luixxiul !
Just some smaller comments (you are cleaning up, so lets do it right 😄 )
weeman1337
reviewed
Jun 2, 2022
|
Vielen Dank für Verifizierung 😃 |
JanBurp
pushed a commit
to JanBurp/matrix-react-sdk
that referenced
this pull request
Jun 14, 2022
* Specify the button style explicitly removing the dependency on the mixin The reset mixin can cause style inconsistencies by disrupting cascading arbitrarily, increasing the number of specified declarations more than needed. Though it might be useful for development, it is not necessary to use it, makes it difficult to grasp the style structure, and can be removed to optimize the structure. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Remove element='button' from AccessibleButton Since AccessibleButton has role='button' by default, setting the element button property is redundant. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Protect mx_ShareType_option from being regressed structurally Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * yarn run lint:style --fix Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Wrap buttons with declarations for spacing box-sizing is not required for the buttons or the wrapper. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * yarn run lint:style --fix Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * fix eslint errors Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Fix LocationShareMenu-test.tsx AccessibleButton is div by default Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Reflect the review Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Revert "Remove element='button' from AccessibleButton" This reverts commit af78d27. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com> * Revert "Fix LocationShareMenu-test.tsx" This reverts commit 7d783a7. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove element='button' from-> should be addressed with another PR.AccessibleButton, which is a redundant setting. If it should be a button HTML element, it is AccessibleButton that should be fixed.Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
type: task
This change is marked as an internal change (Task), so will not be included in the changelog.