Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add git status to the console title / cleanse environment variables #1922

Closed
1 task done
piersmyers opened this issue Mar 14, 2022 · 4 comments
Closed
1 task done
Assignees
Labels
🚀 feat New feature

Comments

@piersmyers
Copy link

piersmyers commented Mar 14, 2022

Code of Conduct

  • I agree to follow this project's Code of Conduct

What would you like to see changed/added?

Please add the ability to include the git status to the console title. I still use Posh Git in my Windows 10 powershell 7 terminal and it does set the POSH_GIT_STATUS environment variable that I could use but OMP doesn't like it to be added to my console_title_template, e.g.:

"console_title_template": "{{ if .Root }}(Admin) {{ end }}{{ .Folder }}{{ .Env.POSH_GIT_STATUS }}"

I assume it is because it is full of escape characters to colourise it. Could it be possible to cleanse this variable so that it can be added to the console title?

@JanDeDobbeleer
Copy link
Owner

@piersmyers confirmed to be ANSI. Will tackle that.

JanDeDobbeleer added a commit that referenced this issue Mar 14, 2022
JanDeDobbeleer added a commit that referenced this issue Mar 14, 2022
@JanDeDobbeleer
Copy link
Owner

@piersmyers

image

@piersmyers
Copy link
Author

Awesome, thank you so much for doing this so quickly Jan, works perfectly now. You're a ⭐.

Copy link

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues.
If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀 feat New feature
Projects
None yet
Development

No branches or pull requests

2 participants