Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery status shows percent symbol twice and causes warning colour #259

Closed
2 tasks done
jakehelme opened this issue Dec 24, 2020 · 1 comment
Closed
2 tasks done
Labels
🐛 bug Something isn't working windows

Comments

@jakehelme
Copy link

jakehelme commented Dec 24, 2020

Prerequisites

  • I have read and understand the CONTRIBUTING guide
  • I looked for duplicate issues before submitting this one

Description

On a fairly regular basis, I get a weird battery status bug where it shows 100%% and that status is incorrectly coloured. In my colour theme, it shows red instead of green. This is what I mean:

image

Environment

  • Oh my Posh version: 3.58.0
  • Theme: jandedobbeleer
  • Operating System: Windows 10 (1909)
  • Shell: PowerShell
  • Terminal: Windows Terminal

Steps to Reproduce

  1. Keep pressing enter until battery status shows double percentage

Expected behavior:
Should just show a single percentage sign and stay green when battery is at 100%.

Actual behavior:
Occassionally see a red battery status with 100%% displayed

Update
I see it happens for Scott Hanselman too as can be seen in one of the screenshots here on his blog.

@JanDeDobbeleer JanDeDobbeleer added 🐛 bug Something isn't working windows labels Dec 24, 2020
JanDeDobbeleer added a commit that referenced this issue Dec 24, 2020
@jakehelme
Copy link
Author

Thank you! The fix is working perfectly 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working windows
Projects
None yet
Development

No branches or pull requests

2 participants