New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add x86 release #298
Comments
We could do an experimental build to see if this all works according to expectations. Adding that build as output isn't the tricky part, validating it could might be. I'll see what I can do. @patriksvensson to be clear, we're talking about a Windows x86 build, right? |
While adding an x86 build we can keep an eye on this: golang/go#36439 |
@JanDeDobbeleer Yes, We're talking about Windows x86 builds. If it becomes too much work or if it becomes difficult to validate or maintain, we could skip adding x86 builds. It's not super important to me and no one else seemed to have asked for it. |
@patriksvensson I'm going to try to give you one for the new year 😉 |
Let me know if this works, because it was waaaay to easy to get this build meaning I'm highly skeptical this is correct. It checks out as a |
@JanDeDobbeleer Awesome! I'm going to try it out later this afternoon or evening when I get some free time 👍 |
@patriksvensson did you find a moment yet to validate this? |
@JanDeDobbeleer Sorry! Been a bit busy. Checking it out now! |
@JanDeDobbeleer Seems to work fine! |
I'll add that to the build output this week 👌🏻 |
@JanDeDobbeleer Awesome! Looking forward to updating my profile scripts 😀 |
@patriksvensson took me a few tries, but it should be there. Can you validate the binary in release 3.69.0? |
@patriksvensson the releases contain an x86 build, I'm closing this issue ;-) |
@JanDeDobbeleer Sorry! I forgot to answer your question. Yes, it's working as expected! |
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. |
Prerequisites
CONTRIBUTING
guideDescription
It would be nice to have a x86 release of oh-my-posh.
The main reason for this is that I would like to use it on my Surface Pro X, which is an ARM64 device. Go is however not supported on ARM64 yet, but it supports x86 emulation, so having an x86 would unblock this scenario.
I'm of course willing to help out with this if you lack the time.
The text was updated successfully, but these errors were encountered: