Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x86 release #298

Closed
2 tasks done
patriksvensson opened this issue Dec 31, 2020 · 15 comments
Closed
2 tasks done

Add x86 release #298

patriksvensson opened this issue Dec 31, 2020 · 15 comments
Labels
🚀 feat New feature

Comments

@patriksvensson
Copy link
Sponsor

patriksvensson commented Dec 31, 2020

Prerequisites

  • I have read and understand the CONTRIBUTING guide
  • I looked for duplicate issues before submitting this one

Description

It would be nice to have a x86 release of oh-my-posh.

The main reason for this is that I would like to use it on my Surface Pro X, which is an ARM64 device. Go is however not supported on ARM64 yet, but it supports x86 emulation, so having an x86 would unblock this scenario.

I'm of course willing to help out with this if you lack the time.

@JanDeDobbeleer
Copy link
Owner

JanDeDobbeleer commented Dec 31, 2020

We could do an experimental build to see if this all works according to expectations. Adding that build as output isn't the tricky part, validating it could might be. I'll see what I can do.

@patriksvensson to be clear, we're talking about a Windows x86 build, right?

@JanDeDobbeleer JanDeDobbeleer added the 🚀 feat New feature label Dec 31, 2020
@lnu
Copy link
Contributor

lnu commented Jan 1, 2021

While adding an x86 build we can keep an eye on this: golang/go#36439

@patriksvensson
Copy link
Sponsor Author

@JanDeDobbeleer Yes, We're talking about Windows x86 builds.

If it becomes too much work or if it becomes difficult to validate or maintain, we could skip adding x86 builds. It's not super important to me and no one else seemed to have asked for it.

@JanDeDobbeleer
Copy link
Owner

@patriksvensson I'm going to try to give you one for the new year 😉

@JanDeDobbeleer
Copy link
Owner

posh-windows-386.zip

Let me know if this works, because it was waaaay to easy to get this build meaning I'm highly skeptical this is correct. It checks out as a PE32 executable (console) Intel 80386 (stripped to external PDB), for MS Windows executable so 🤞🏻

@patriksvensson
Copy link
Sponsor Author

@JanDeDobbeleer Awesome! I'm going to try it out later this afternoon or evening when I get some free time 👍

@JanDeDobbeleer
Copy link
Owner

@patriksvensson did you find a moment yet to validate this?

@patriksvensson
Copy link
Sponsor Author

@JanDeDobbeleer Sorry! Been a bit busy. Checking it out now!

@patriksvensson
Copy link
Sponsor Author

@JanDeDobbeleer Seems to work fine!

image

@JanDeDobbeleer
Copy link
Owner

I'll add that to the build output this week 👌🏻

@patriksvensson
Copy link
Sponsor Author

@JanDeDobbeleer Awesome! Looking forward to updating my profile scripts 😀

JanDeDobbeleer added a commit that referenced this issue Jan 9, 2021
JanDeDobbeleer added a commit that referenced this issue Jan 9, 2021
JanDeDobbeleer added a commit that referenced this issue Jan 9, 2021
@JanDeDobbeleer
Copy link
Owner

@patriksvensson took me a few tries, but it should be there. Can you validate the binary in release 3.69.0?

@JanDeDobbeleer
Copy link
Owner

@patriksvensson the releases contain an x86 build, I'm closing this issue ;-)

@patriksvensson
Copy link
Sponsor Author

@JanDeDobbeleer Sorry! I forgot to answer your question. Yes, it's working as expected!

Copy link

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues.
If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀 feat New feature
Projects
None yet
Development

No branches or pull requests

3 participants