Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black arrow in some segments of theme JanDeDobbeleer are black if using background image in Window terminal #322

Closed
2 tasks done
Fubuchi opened this issue Jan 6, 2021 · 4 comments
Closed
2 tasks done

Black arrow in some segments of theme JanDeDobbeleer are black if using background image in Window terminal #322

Fubuchi opened this issue Jan 6, 2021 · 4 comments

Comments

@Fubuchi
Copy link

Fubuchi commented Jan 6, 2021 •
edited

Prerequisites

  • I have read and understand the CONTRIBUTING guide
  • I looked for duplicate issues before submitting this one

Description

In Window terminal, when I use theme JanDeDobbeleer there are some black arrows between segments if I use background image (backgroundImage option) instead of transparent arrows. It isn't the case if I use background color (background option).

Even if I use a single color image, the black arrow still appear:

image

Environment

  • Oh my Posh version: 3.68.4
  • Theme: JanDeDobbeleer
  • Operating System: Win 10 1909
  • Shell: Powershell 7.1
  • Terminal: Window terminal 1.5.3142.0
@JanDeDobbeleer
Copy link
Owner

That's a Windows terminal issue. The arrow is transparent but Windows Terminals for some reason adds black rather than the bg image. Can you log the issue there?

@JanDeDobbeleer
Copy link
Owner

@Fubuchi there might be some more information here (and a way to turn it on). If that's not the issue, then it's going to be this one.

JanDeDobbeleer added a commit that referenced this issue Mar 14, 2021
@JanDeDobbeleer
feat: set terminal background color
4d628a3 
relates to #529
relates to #322
relates to #497

Windors terminal and Visual Studio Code do not work well with inversted
ANSI sequences. This weak allows users to override the Tranparency to
the terminal background color removing black elements in their prompt.

Ideally we remove this once they are on par with other terminals, but
that could take a while.

See microsoft/vscode#111762
and microsoft/terminal#7014
JanDeDobbeleer added a commit that referenced this issue Mar 14, 2021
@JanDeDobbeleer
feat: set terminal background color
e6247da 
relates to #529
relates to #322
relates to #497

Windors terminal and Visual Studio Code do not work well with inversted
ANSI sequences. This weak allows users to override the Tranparency to
the terminal background color removing black elements in their prompt.

Ideally we remove this once they are on par with other terminals, but
that could take a while.

See microsoft/vscode#111762
and microsoft/terminal#7014
@Piervn
Copy link

Piervn commented Nov 2, 2023

What is the solution to this problem?

@JanDeDobbeleer
Copy link
Owner

@Piervn using the Atlas renderer in Windows Terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JanDeDobbeleer @Fubuchi @Piervn