New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrupted prompt after certain commands #352
Comments
It is known that the git tooling in Windows can cause the entire terminal rendering to act weird due to overriding certain variables. I'll check, but can't promise this is something that can be fixed within oh-my-posh. |
I did the same test with starship and it works. Maybe we can check what they do on their side with the powershell prompt. |
@lnu could you also reproduce the issue for OMP? |
powershell core 7.1.1 here in windows terminal |
Only added
|
@lnu @peter-dolkens so this is confirmed to only break in PSCore, for me that's There's a reason I went with the current invocation technique as I did use a starship like invocation which ruined the rendering on certain machines. This solution made it work everywhere. There's something in the output of that command which ruins the rendering, and the next |
@lnu @peter-dolkens fixed it. I believe, at the time, I was battling combination of issues which led me down this path. I was able to directly invoke OMP now without the entire |
Great work - @JanDeDobbeleer! Was a low-priority bug for me, but thought I had an easy enough repro for it to be worthwhile logging =D |
I think I tested everything, also simplified the module in the meantime. Hope I didn't break anything for someone else 🤞🏻 |
@kidchenko-tw That's likely going to be a Hyper issue, allow me to check. Is everything up to date? |
@kidchenko-tw I can't reproduce this |
Yes, everything is up to date, I will double check, I remember I already had this problem in the past... But can't remember the fix, |
@kidchenko-tw can you copy the prompt here? If you pipe the out of oh-my-posh with your config I can have a look. Maybe there's a character the ruins the ANSI sequences? |
Oh my Posh version: 3.131.0 |
Aha git diff. That's going to be the culprit. Did you update git as well? |
Just updated my git git version 2.31.1.windows.1 Still same problem :/ |
I'll try to reproduce this. |
@kidchenko-tw I just tried to reproduce this again, doesn't happen. Did you add a specific pager or something else in your git config that influences |
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. |
Prerequisites
CONTRIBUTING
guideDescription
When running grep, the prompt immediately afterwards is corrupted - not sure if there's other commands with similar issues yet.
Environment
Steps to Reproduce
echo hi | grep hi
Expected behavior: [What you expected to happen]
Actual behavior: [What actually happened]
Notes
Theme
The text was updated successfully, but these errors were encountered: