Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of conda environment not showing in the Python segment #360

Closed
2 tasks done
sobayed opened this issue Jan 20, 2021 · 3 comments
Closed
2 tasks done

Name of conda environment not showing in the Python segment #360

sobayed opened this issue Jan 20, 2021 · 3 comments

Comments

@sobayed
Copy link

sobayed commented Jan 20, 2021

Prerequisites

  • I have read and understand the CONTRIBUTING guide
  • I looked for duplicate issues before submitting this one

Description

In version 3.77.0, the name of the conda environment is not showing anymore in the Python segment (only the Python logo and version):

oh-my-posh_3 77 0_missing_conda_name

In version 3.68.4, this was still working properly:

oh-my-posh_3 68 4_conda_name_showing

Environment

  • Oh my Posh version: 3.77.0
  • Theme: Paradox
  • Operating System: Windows 10 (Version 10.0.18363 Build 18363)
  • Shell: Powershell 7.1.0
  • Terminal: Windows Terminal 1.4.3243.0

Steps to Reproduce

  1. Open Windows Terminal with Powershell and an active conda environment
  2. Name of the conda environment is not showing in the Python segment
  3. Changing conda environments does not fix the issue

Expected behavior: Name of the conda environment is showing in the Python segment

Actual behavior: Name of the conda environment missing in the Python segment

@JanDeDobbeleer
Copy link
Owner

@sobayed you're right. I removed CONDA_DEFAULT_ENV. Can you tell me you want to see base or only when the env name != base?

JanDeDobbeleer added a commit that referenced this issue Jan 20, 2021
JanDeDobbeleer added a commit that referenced this issue Jan 20, 2021
@sobayed
Copy link
Author

sobayed commented Jan 20, 2021

My personal preference would be to always show the environment name (including base), as it did with the previous versions. But maybe having a config parameter for that in the Python section would also be an option.

@JanDeDobbeleer
Copy link
Owner

@sobayed I'll remove that logic for now, if it ever pops up as a request that can always be implemented. You'll see this drop after my lunch.

JanDeDobbeleer added a commit that referenced this issue Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants