Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node segment improvement #378

Closed
2 tasks done
roterob opened this issue Feb 4, 2021 · 4 comments
Closed
2 tasks done

Node segment improvement #378

roterob opened this issue Feb 4, 2021 · 4 comments
Labels
🤩 enhancement Improvement of a feature

Comments

@roterob
Copy link

roterob commented Feb 4, 2021

Prerequisites

  • I have read and understand the CONTRIBUTING guide
  • I looked for duplicate issues before submitting this one

Description

It would be amazing if node segment could check the existence of .nvm file and warning (change segment color) if current node version doesn't mach with .nvm version.

I'm learning go only for this :) but I guess need some help.

@JanDeDobbeleer
Copy link
Owner

JanDeDobbeleer commented Feb 5, 2021

.nvm file is an easy extension (add it here), version file offset requires additional changes especially given that languages have the same base. But perfectly doable.

@roterob
Copy link
Author

roterob commented Feb 5, 2021

Yep, maybe is better take as base git segment... Let me know if there is a better approach.

@JanDeDobbeleer
Copy link
Owner

@roterob I have the basis ready, can you give me the contents of .nvm?

@JanDeDobbeleer JanDeDobbeleer added the 🚀 feat New feature label Feb 6, 2021
JanDeDobbeleer added a commit that referenced this issue Feb 7, 2021
JanDeDobbeleer added a commit that referenced this issue Feb 7, 2021
JanDeDobbeleer added a commit that referenced this issue Feb 7, 2021
@roterob
Copy link
Author

roterob commented Feb 7, 2021

The most common way to generate a .nvm file is node --version > .nvm. Is a file with the node version that the current project should use.

@JanDeDobbeleer JanDeDobbeleer added 🤩 enhancement Improvement of a feature and removed 🚀 feat New feature labels Feb 10, 2021
JanDeDobbeleer added a commit that referenced this issue Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤩 enhancement Improvement of a feature
Projects
None yet
Development

No branches or pull requests

2 participants