New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing trailing space from upstream icons, introduced in 19.17.2, cuts off half the icon. #4784
Closed
1 task done
Labels
🐛 bug
Something isn't working
Comments
This is actually a Windows Terminal bug as it incorrectly cuts the icon. I thought they already fixed this, but alas. |
@pkropachev check, I'm going to revert that change. It indeed is better off with a space by default. Must've been a bit asleep when I did that. |
4 tasks
@pkropachev it's a literal revert, bo additional spaces were added. |
@JanDeDobbeleer, thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
What happened?
When installing v19.17.2, all my upstream icons are cut in half. I tried with several different default themes and Nerd fonts and each one renders the same. Fonts I used are CaskaydiaCove and FiraCode, each one only showing half the icon (Github and Bitbucket).
DOESN'T WORK: v19.17.2 and above (icon cut in half):
WORKS: v19.17.1 and below (full icon)
Theme
No theme (the default), but I also tried a handful from themes page, and they all render incorrectly.
What OS are you seeing the problem on?
Windows
Which shell are you using?
powershell
Log output
The text was updated successfully, but these errors were encountered: