Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH Segment or SSH handling in Session #48

Closed
2 tasks done
nwykes opened this issue Oct 9, 2020 · 3 comments
Closed
2 tasks done

SSH Segment or SSH handling in Session #48

nwykes opened this issue Oct 9, 2020 · 3 comments
Labels
🤩 enhancement Improvement of a feature

Comments

@nwykes
Copy link
Contributor

nwykes commented Oct 9, 2020

Prerequisites

  • I have read and understand the CONTRIBUTING guide
  • I looked for duplicate issues before submitting this one

Description

I'd like to add some special handling if detected running in an ssh session.

Would an ssh specific segment be best for this? Or would some properties on the hostname in the session segment be more appropriate. I'm thinking like ssh-foreground, ssh-background, ssh-icon.

Environment

  • Oh my Posh version: 3.11.2
  • Theme: all
  • Operating System: all
  • Shell: all
  • Terminal: all
@JanDeDobbeleer
Copy link
Owner

JanDeDobbeleer commented Oct 9, 2020

properties on the hostname in the session segment

I would opt for that as well. It's part of your session. Not sure of we should have color overrides specifically although It could make sense for foreground rather than background (might get messy and as soon as you're allowing partly overrides for all the colors a separate segment makes more sense imho).

If we make a ssh-separator we can display it as jan@machine on sshcontext for example with on set as that text.

@JanDeDobbeleer JanDeDobbeleer added the 🤩 enhancement Improvement of a feature label Oct 14, 2020
JanDeDobbeleer added a commit that referenced this issue Nov 3, 2020
@JanDeDobbeleer
Copy link
Owner

Screenshot 2020-11-03 at 20 16 04

@nwykes
Copy link
Contributor Author

nwykes commented Nov 4, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤩 enhancement Improvement of a feature
Projects
None yet
Development

No branches or pull requests

2 participants