Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After changing the themes wrong font is loaded? #5

Closed
Cruik opened this issue Sep 17, 2020 · 18 comments
Closed

After changing the themes wrong font is loaded? #5

Cruik opened this issue Sep 17, 2020 · 18 comments
Assignees
Labels
🐛 bug Something isn't working windows

Comments

@Cruik
Copy link

Cruik commented Sep 17, 2020

HEy,

i installed it like you provided but i guess the wring font is loaded.
Can you give me a hint what i am missing ?
grafik

@JanDeDobbeleer
Copy link
Owner

Interesting. It seems the terminal doesn't support ANSI characters, I might have to check that on a Windows machine itself. I used to develop this on ConEmu initially where everything worked, but it seems that's not necessarily true everywhere. I'll see what needs to be done here. Can you provide some information on your current setup (terminal/os/..)?

@JanDeDobbeleer JanDeDobbeleer self-assigned this Sep 17, 2020
@JanDeDobbeleer JanDeDobbeleer added 🐛 bug Something isn't working windows labels Sep 17, 2020
@Cruik
Copy link
Author

Cruik commented Sep 18, 2020

Yeah sure. here is my current setup:
Windows 10 Enterprise
Version 1909

Windows Terminal
Version: 1.2.2381.0

PowerShell 7.0.3

I m using Windows Terminal which starts powershell which loads your Module (go-my-posh)

@JanDeDobbeleer
Copy link
Owner

I can reproduce this. But the fix is annoyingly hard. It comes down to ANSI color codes not working out of the box, and I need to enable that from an application POV. Stay tuned.

@Cruik
Copy link
Author

Cruik commented Sep 19, 2020

Alright, keep up the good work!

@JanDeDobbeleer
Copy link
Owner

Found the issue, will push a new version!

JanDeDobbeleer added a commit that referenced this issue Sep 19, 2020
@JanDeDobbeleer
Copy link
Owner

@Cruik you will also need Meslo LGM NF to have the icons which are set in the theme.

JanDeDobbeleer added a commit that referenced this issue Sep 19, 2020
@JanDeDobbeleer
Copy link
Owner

Almost there, the colors now render correctly but the prompt function is complaining on something.
image

@JanDeDobbeleer
Copy link
Owner

Getting closer, found why the rendering of the colors was broken but that effectively ruins the characters...
image

@JanDeDobbeleer
Copy link
Owner

Fix that too, but I don't like the fix for now. I'm going to have a clear look in the morning and push a working build at that time.

JanDeDobbeleer added a commit that referenced this issue Sep 20, 2020
JanDeDobbeleer added a commit that referenced this issue Sep 20, 2020
@JanDeDobbeleer
Copy link
Owner

New version should be out ASAP. Can you confirm this now works on your machine as well?

@Cruik
Copy link
Author

Cruik commented Sep 20, 2020

getting the same error as you with the promptfunction
88 the handle is invalid

@JanDeDobbeleer
Copy link
Owner

JanDeDobbeleer commented Sep 20, 2020

Ah yes. I forgot something obvious. That issue comes from a dependency where I did a fix locally, but then obviously I have to fork it and adjust 🤦🏻‍♂️

@JanDeDobbeleer
Copy link
Owner

@Cruik I just published 0.4.1 with the fix, on my machine when removing all other versions and a fresh install, it works.

@Cruik
Copy link
Author

Cruik commented Sep 20, 2020

with the new version it works now on my machine.
The only character which is not displaying correctly is the arrow in the next line or am i missing there a font ?
grafik

@Cruik
Copy link
Author

Cruik commented Sep 20, 2020

i also noticed another missing character
the line above is the displayed line with go-my-posh
the line down under is from a terminal with oh-my-posh
grafik

@JanDeDobbeleer
Copy link
Owner

Which font is that? I develop everything with MesloLGM NF. I'll update the README accordingly. You can tweak those settings easily by adjusting (or copy pasting the theme JSON, adjusting the icons and setting that file location as the theme. I really need to create that guide next.

@Cruik
Copy link
Author

Cruik commented Sep 20, 2020

i used the wront, blame on me...
i used Cascadia Code PL, with the MesloLGMNF it displays fine!

Thanks for your work and your help!

@JanDeDobbeleer
Copy link
Owner

Thank YOU for trying this out and the donation! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working windows
Projects
None yet
Development

No branches or pull requests

2 participants