Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"disable_notice": true is not working as expected #5124

Closed
1 task done
joselcaguilar opened this issue Jun 19, 2024 · 3 comments
Closed
1 task done

"disable_notice": true is not working as expected #5124

joselcaguilar opened this issue Jun 19, 2024 · 3 comments
Assignees
Labels
🤩 enhancement Improvement of a feature

Comments

@joselcaguilar
Copy link

Code of Conduct

  • I agree to follow this project's Code of Conduct

What happened?

I would like to have auto_upgrade and disable_notice set to true, however, when I open a new pwsh session (in my case 7.4.2) the upgrade notice is still visible at the beginning:
image

Theme

{
  "$schema": "https://raw.githubusercontent.com/JanDeDobbeleer/oh-my-posh/main/themes/schema.json",
  "version": 2,
  "final_space": true,
  "auto_upgrade": true,
  "disable_notice": true,
  .....

What OS are you seeing the problem on?

Windows

Which shell are you using?

powershell

Log output

NA
@joselcaguilar joselcaguilar added the 🐛 bug Something isn't working label Jun 19, 2024
@JanDeDobbeleer
Copy link
Owner

@joselcaguilar this is by design, but you could argue that it's OK to only display the actual upgrade being done and not when there's no update available. I'll adjust that.

@JanDeDobbeleer JanDeDobbeleer added 🤩 enhancement Improvement of a feature and removed 🐛 bug Something isn't working labels Jun 19, 2024
@joselcaguilar
Copy link
Author

@joselcaguilar this is by design, but you could argue that it's OK to only display the actual upgrade being done and not when there's no update available. I'll adjust that.

Yup, that's what I expected when disable_notice is set to true, thanks @JanDeDobbeleer

@JanDeDobbeleer
Copy link
Owner

I'm taking this in the PR I'm prepping for tomorrow probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤩 enhancement Improvement of a feature
Projects
None yet
Development

No branches or pull requests

2 participants