Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add git origin symbols to git segment logic #7

Closed
JanDeDobbeleer opened this issue Sep 17, 2020 · 5 comments
Closed

feat: add git origin symbols to git segment logic #7

JanDeDobbeleer opened this issue Sep 17, 2020 · 5 comments
Labels
🚀 feat New feature 🐣 good first issue Good for newcomers

Comments

@JanDeDobbeleer
Copy link
Owner

oh-my-posh supports showing origin symbols for git repositories (github/gitlab/bitbucket), so go-my-posh should have this as well.
@JanDeDobbeleer JanDeDobbeleer added 🚀 feat New feature 🐣 good first issue Good for newcomers labels Sep 17, 2020
@nwykes
Copy link
Contributor

nwykes commented Oct 6, 2020

I've started working on this. WIP is at https://github.com/nwykes/oh-my-posh3/tree/git_origin

@JanDeDobbeleer
Copy link
Owner Author

I've started working on this. WIP is at https://github.com/nwykes/oh-my-posh3/tree/git_origin

The icon names are already fine, should be rather straightforward. How comfortable are you with golang?

@nwykes
Copy link
Contributor

nwykes commented Oct 6, 2020

I've tinkered with golang.

it's working for me locally, trying to build some tests for it and the associated doc updates, etc.

Should it default to on or off?

@JanDeDobbeleer
Copy link
Owner Author

Should it default to on or off?

Looking at V2 it's off by default so I'd opt for that.

JanDeDobbeleer added a commit that referenced this issue Oct 11, 2020
@JanDeDobbeleer
feat(git): add upstream icons
3e5caa9 
resolves #7
JanDeDobbeleer added a commit that referenced this issue Oct 11, 2020
@JanDeDobbeleer
feat(git): add upstream icons
7bd80ba 
resolves #7
JanDeDobbeleer added a commit that referenced this issue Oct 11, 2020
@JanDeDobbeleer
feat(git): add upstream icons
4342e00 
resolves #7
JanDeDobbeleer added a commit that referenced this issue Oct 11, 2020
@JanDeDobbeleer
feat(git): add upstream icons
15cab62 
resolves #7
@JanDeDobbeleer
Copy link
Owner Author

@nwykes I finished this one. Given that I reworked the git functionality quite a bit, I'm focusing on finishing it. Once this is feature complete (revert and bisect still to be done), everything should be on par with V2.

NikolaRHristov added a commit to NikolaRHristov/PowerShell that referenced this issue Aug 16, 2023
@NikolaRHristov
Merge pull request JanDeDobbeleer#7 from nikolaxhristov/dependabot/np…
9c4f2e9 
…m_and_yarn/website/json5-2.2.3

chore(deps): bump json5 from 2.2.1 to 2.2.3 in /website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚀 feat New feature 🐣 good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nwykes @JanDeDobbeleer