Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperlink breaks formatting #843

Closed
2 tasks done
JBanks opened this issue Jul 6, 2021 · 1 comment · Fixed by #845
Closed
2 tasks done

hyperlink breaks formatting #843

JBanks opened this issue Jul 6, 2021 · 1 comment · Fixed by #845
Labels
🐛 bug Something isn't working

Comments

@JBanks
Copy link

JBanks commented Jul 6, 2021

Prerequisites

  • I have read and understood the CONTRIBUTING guide
  • I have looked for duplicate issues before submitting this one

Description

With hyperlink enabled
image
Without hyperlink enabled
image
Theme section in question

"type": "path",
"style": "plain",
"foreground": "#fafafa",
"properties": {
  "prefix": "<#CB4B16>[</>",
  "postfix": "<#CB4B16>]</>",
  "style": "mixed",
  "folder_separator_icon": " \uE0B1 ",
  "enable_hyperlink": true

Environment

  • Oh My Posh version: 3.166.3
  • Theme: darkblood derivative
  • Operating System: Windows 10
  • Shell: PowerShell
  • Terminal: Windows Terminal 1.8.1521.0

Steps to Reproduce

  1. Use a darkblood-like theme with square braces
  2. Add "enable_hyperlink": true to the path properties of the theme.

Expected behavior: Hyperlink is generated only for the path portion of the prompt.

Actual behavior: Hyperlink includes the prefixed square brace.

@JanDeDobbeleer JanDeDobbeleer added the 🐛 bug Something isn't working label Jul 6, 2021
JanDeDobbeleer added a commit that referenced this issue Jul 10, 2021
JanDeDobbeleer added a commit that referenced this issue Jul 10, 2021
Copy link

github-actions bot commented Apr 8, 2024

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues.
If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants