Exit code does not work in PowerShell

[krzysdz]

Prerequisites

• I have read and understood the CONTRIBUTING guide
• I have looked for duplicate issues before submitting this one

Description

After 9576e82 exit code detection stopped working in PowerShell and success is always signalled, because $? is captured too late.

Moving the lines 78-79 to the top of the ScriptBlock solves the problem.

oh-my-posh/src/init/omp.ps1

Lines 70 to 79 in 2aa00da

	$omp = "::OMP::"
	$config, $cleanPWD, $cleanPSWD = Get-PoshContext
	if ($global:PoshSettings.Transient -eq $true) {
	$standardOut = @(&$omp --pwd="$cleanPWD" --pswd="$cleanPSWD" --config="$config" --print-transient 2>&1)
	$standardOut -join "`n"
	$global:PoshSettings.Transient = $false
	return
	}
	#store if the last command was successful
	$lastCommandSuccess = $?

Environment

• Oh My Posh version: 3.168.2 / 3.166.3
• Theme: slimfat
• Operating System: Windows 10 21H1 / Windows 11 (22000.65 co_release)
• Shell: PowerShell 7.1.3
• Terminal: Windows Terminal Dev / Preview

Optional

• posh-git version: 1.0.0
• git version: 2.32.0.windows.2

Steps to Reproduce

1. Select a theme with exit code. I used slimfat.
2. Execute command exiting with 0.
3. Execute command exiting with something other than 0, e.g. python -c "exit(1)".

Expected behavior:

Appropriate exit status and code are shown.

Actual behavior:

Success is always shown, regardless of the exit code.

[JanDeDobbeleer]

@krzysdz absolutely right. I'm an idiot.

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues.
If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.