Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pwsh): force session to UTF8 #528

Merged
merged 1 commit into from Mar 14, 2021
Merged

feat(pwsh): force session to UTF8 #528

merged 1 commit into from Mar 14, 2021

Conversation

JanDeDobbeleer
Copy link
Owner

@JanDeDobbeleer JanDeDobbeleer commented Mar 14, 2021

Prerequisites

  • I have read and understand the CONTRIBUTING guide
  • The commit message follows the conventional commits guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Description

Force the current Powershell session to use UTF8. As we see A LOT of issues with encoding and Powershell will move towards UTF8 in the near™️ future, it might be a good idea to already do so here.

@travistx @lnu thoughts?

@tradiff
Copy link
Contributor

tradiff commented Mar 14, 2021

@travistx @lnu thoughts?

I've been using UTF8 for a while, and haven't seen any issues. But I only use Windows / Windows Terminal / English. I just did a bit of testing with the default Powershell 7 terminal and Powershell 5.1 and it seemed to behave normally.

@lnu
Copy link
Contributor

lnu commented Mar 14, 2021

Let me check it with powershell on macOS.

=> no issue whatsoever
Maybe a message could be printed when the module is loaded and the encoding changed? so people knows the module changed the encoding, which can affect other unrelated things.

@JanDeDobbeleer
Copy link
Owner Author

It shouldn't do much weird stuff, but you never know.

@lnu
Copy link
Contributor

lnu commented Mar 14, 2021

not related but

image

issue with the last commit(echo " "):
image

@JanDeDobbeleer
Copy link
Owner Author

JanDeDobbeleer commented Mar 14, 2021

Oh fork no. Hold on. I messed up.

EDIT: fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants