feat: improved theme png rendering #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall this improves glyph rendering in the theme PNGs for docs. Changes: - Replaces VictorMono with latest Hack nerd font - When calculating overall width, count glyphs as double wide - When rendering a glyph, allow ~1.7x space (this seemed right testing many) I hope this is a net improvement that helps theme renders be a bit more accurate and shine!
1.7 introduces some odd offset problems with some backgrounds - 2x is stable.
https://github.com/ryanoasis/nerd-fonts/wiki/Glyph-Sets-and-Code-Points ...checking those points for nerd font glyphs in play I'm unfamiliar with Go here and maybe there's a better way to implement, but the results are much improved.
Go checks were unhappy - this isn't a hot path so breaking it out into a format that matches the docs, for easier maintenance.
...but I hope this works - bit simpler layout to maintain too.
JanDeDobbeleer
approved these changes
Sep 18, 2021
|
@NickCraver this isn't a bad take. To be honest, I was so happy to get this to work in the first place, so this part of the codebase can be pragmatic. Will there be a cleaner way? Probably. Is there a lot of ROI when spending the time on it? Highly unlikely. |
| @@ -320,9 +372,11 @@ func (ir *ImageRenderer) SavePNG(path string) error { | |||
| } | |||
|
|
|||
| w, h := dc.MeasureString(str) | |||
| w += (w * float64(ir.runeAdditionalWidth(runes[0]))) | |||
There was a problem hiding this comment.
this is done to double the width or not, right?
There was a problem hiding this comment.
Indeed! I tried to go through and add comments on all points. It was light on comments before so wasn't sure on stance there, but hopefully the additions here are good - happy to tweak more!
Good PR feedback - adding some more commentary for anyone coming across these bits later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
CONTRIBUTINGguideDescription
This is making the following changes to the PNG render pipeline for themes:
Here are some example before (based on current website) and with this change:
Some things I don't love:
...is this a bad idea? I'm not sure - I hope it helps or sparks another idea at least. My feeling is the result is a net win (unless people hate the font!), but the implementation is icky. If the gut reaction to this is "omg Nick, wtf?!?" I don't mind it getting closed one bit, only trying to explore a possible path here to make the themes a bit more accurate in the previews.