New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export wb_comment()
#758
Export wb_comment()
#758
Conversation
…new spreadsheet software behaviour.
… `create_comment()`
Merge commit 'fc908298037f085aff54c0b5bac78e90eed0d974' #Conflicts: # R/class-comment.R # R/class-workbook-wrappers.R # _pkgdown.yml # man/comment.Rd
After my initial complains ... I can live with this and we can merge prior to 1.0, aka I have no objection. Please test with threaded comments too. |
Should a deprecation warning be issued in |
Threaded comments do not seem to use |
IIRC threaded comments use create_comment() internally. Even though it's a duplication I'd prefer to not yet deprecate |
Sounds good. Everything is ready. Deprecation is only if the option is set, like other ones. I will finalize the cleanup of FYI, I plan to
|
Proof of concept as discussed in #754
create_comment()
in any way. It will continue working as it did before.visible
default to FALSE inwb_comment()
to account for new Excel behaviour. (i.e. when I create a note in Excel, by default, it is not displayed)author
.comment
inwb_add_comment()
. Most times, you just want to use the defaults.I will revamp examples and vignettes for that. So, I will be able to check if things are not working as expected.
I removed the default options to
wbComment
because it is not exported.I completed the options list as some were missing from the list.