Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export wb_comment() #758

Merged
merged 8 commits into from Aug 23, 2023
Merged

Export wb_comment() #758

merged 8 commits into from Aug 23, 2023

Commits on Aug 23, 2023

  1. working example.

    @olivroy
    olivroy committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    9bf0a39 View commit details
    Browse the repository at this point in the history

  2. Change default to visible = FALSE in wb_comment() to account for … 

    …new spreadsheet software behaviour.
    @olivroy
    olivroy committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    6cf1d08 View commit details
    Browse the repository at this point in the history

  3. lint

    @olivroy
    olivroy committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0eaacc3 View commit details
    Browse the repository at this point in the history

  4. Different behaviour on multiple width and height in wb_comment() vs… 

    … `create_comment()`
    @olivroy
    olivroy committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    43de8dc View commit details
    Browse the repository at this point in the history

  5. Merge main branch 

    Merge commit 'fc908298037f085aff54c0b5bac78e90eed0d974'

#Conflicts:
#	R/class-comment.R
#	R/class-workbook-wrappers.R
#	_pkgdown.yml
#	man/comment.Rd
    @olivroy
    olivroy committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0e9c782 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into wb-comment

    @olivroy
    olivroy committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    11efa09 View commit details
    Browse the repository at this point in the history

  7. tweaks to make the overall diff more pleasant to look at.

    @olivroy
    olivroy committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f8bf5e6 View commit details
    Browse the repository at this point in the history

  8. Tweaks and show fmt_txt

    @olivroy
    olivroy committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    bceecb0 View commit details
    Browse the repository at this point in the history