Misc doc edits #936
Merged
Misc doc edits #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMarvin
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Thanks and good catch!
I was wondering, if we should add more #' @inherits details wb_foo in the class workbook documentation, because currently it is a long and rather useless dump of #' @param foo foo graveyard. But I haven't looked into this and *sigh* I do not really care enough
|
I can check it out, but there are still many bugs in roxygen2 R6 handling, so I don't think it is worth playing there, unless you find it difficult to maintain! |
|
Oh alright, probably not worth the hassle. Though I somehow doubt that they will be ever solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet done for the vignette, but thought I'd send these editorial changes.
I adapted what you put in
openxlsx2-packageto add to the class docs.Corrected a link in README that takes us to an unused page as well.