Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wb_add_data() error message when no worksheet #942

Merged
merged 8 commits into from Feb 14, 2024
Merged

Improve wb_add_data() error message when no worksheet #942

merged 8 commits into from Feb 14, 2024

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Feb 14, 2024

Before this, I got

wb_workbook()$add_data(x = mtcars)
Erreur dans wb$is_chartsheet[[sheet]] : 
  tentative de sélection de moins d'un élément dans integerOneIndex

Also added an example of adding a URL hyperlink (I didn't know how to do this, so I documented it!) + added a NEWS bullet + re-rendered README since I forgot to do so in #936

README.md Outdated Show resolved Hide resolved
R/write.R Show resolved Hide resolved
Copy link
Owner

@JanMarvin JanMarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good!

@olivroy olivroy merged commit f84c5ae into main Feb 14, 2024
9 checks passed
@olivroy olivroy deleted the rel branch February 14, 2024 21:54
@olivroy olivroy changed the title Improve error message when no worksheet Improve wb_add_data() error message when no worksheet Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants