Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify case (displayUnits = 'volts'; thresholdUnits = 'rms'; spike-triggered waveform) #6

Closed
vijayiyer05 opened this issue Dec 11, 2018 · 2 comments
Closed

Verify case (displayUnits = 'volts'; thresholdUnits = 'rms'; spike-triggered waveform) #6

vijayiyer05 opened this issue Dec 11, 2018 · 2 comments
Labels
bug Something isn't working
Milestone
1.0

Comments

@vijayiyer05
Copy link
Collaborator

Is the mean-subtraction on the display (as currently applied) the right thing to do for this case?
@vijayiyer05 vijayiyer05 added question Further information is requested verify and removed question Further information is requested labels Dec 11, 2018
@vijayiyer05 vijayiyer05 added bug Something isn't working and removed verify labels Apr 12, 2019
@vijayiyer05 vijayiyer05 added this to the 1.0 milestone Apr 12, 2019
@vijayiyer05
Copy link
Collaborator Author

Observed this issue together with @davidackerman . Switching between RMS & voltage triggered modes, we observed the same transients appearing in either case, but with a mean offset on the same voltage display scale.

@vijayiyer05 vijayiyer05 mentioned this issue Apr 12, 2019
Open
@vijayiyer05 vijayiyer05 added enhancement New feature or request stretch goal bug Something isn't working and removed bug Something isn't working enhancement New feature or request stretch goal labels Apr 12, 2019
@vijayiyer05
Copy link
Collaborator Author

Concluded that it makes sense to leave the baseline mean subtraction for all cases where it's possible (including this one). See updated comments at 4c5498e.

In future could consider whether baseline mean subtraction shoudl be a separate option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@vijayiyer05