Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A flat artifact (apparently zero-valued in volts) appears prior to detected threshold-artifacts #33

Open
vijayiyer05 opened this issue Apr 12, 2019 · 1 comment
Open

A flat artifact (apparently zero-valued in volts) appears prior to detected threshold-artifacts #33

vijayiyer05 opened this issue Apr 12, 2019 · 1 comment
Labels
bug Something isn't working stretch goal verify
Milestone
1.0

Comments

@vijayiyer05
Copy link
Collaborator

Clearest way to reproduce it: use RMS threshold with zero threshold, particularly unfiltered.

Sometimes the values don't appear to be zero, but this seems related to #6 .
@vijayiyer05 vijayiyer05 added the bug Something isn't working label Apr 12, 2019
@vijayiyer05 vijayiyer05 added this to the 1.0 milestone Apr 12, 2019
@davidackerman
Copy link
Collaborator

Function znstStoreReducedData_Waveforms should be reviewed again closely. The 'early waveform' case seemed intended for only a Spoke startup transient but is actually being executed everytime the crossing's waveform range reaches back into a prior refresh period. The partialWaveformBuffer doesn't seem to be employed to help fill those in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working stretch goal verify
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@davidackerman @vijayiyer05