Fix crash android dispose nullpointerdereference (maplibre#203)

Fix issue maplibre#182 --------- Co-authored-by: m0nac0 <58807793+m0nac0@users.noreply.github.com>
JanikoNaber · Aug 23, 2023 · 8eec27b · 8eec27b
1 parent 0e29641
commit 8eec27b
Show file tree

Hide file tree

Showing 18 changed files with 605 additions and 158 deletions.
diff --git a/.github/workflows/flutter_ci.yml b/.github/workflows/flutter_ci.yml
@@ -4,7 +4,7 @@ on: [push, pull_request, workflow_dispatch]
 
 env:
   FLUTTER_CHANNEL: 'stable'
-  FLUTTER_VERSION: '2.10.5'
+  FLUTTER_VERSION: '3.7.7'
 
 jobs:
   format:

diff --git a/README.md b/README.md
@@ -149,6 +149,11 @@ buildTypes {
 }
 ```
 
+## Flutter 3.x.x issues
+Since Flutter 3.x.x was introduced, it exposed some race conditions resulting in occasional crashes upon map disposal. The parameter `useDelayedDisposal` was introduced as a workaround for this issue until Flutter and/or Maplibre fix this issue properly. Use with caution.
+
+
+
 ### iOS app crashes on startup
 
 Please include the `NSLocationWhenInUseUsageDescription` as described [here](#location-features)

diff --git a/example/android/app/build.gradle b/example/android/app/build.gradle
@@ -26,7 +26,7 @@ apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
 
 android {
     compileSdkVersion 31
-    ndkVersion "20.1.5948944"
+    ndkVersion "21.1.6352462"
 
     lintOptions {
         disable 'InvalidPackage'
@@ -35,7 +35,7 @@ android {
     defaultConfig {
         // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
         applicationId "com.mapbox.mapboxglexample"
-        minSdkVersion 20
+        minSdkVersion 21
         targetSdkVersion 31
         versionCode flutterVersionCode.toInteger()
         versionName flutterVersionName

diff --git a/example/lib/line.dart b/example/lib/line.dart
@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import 'dart:async';
-import 'dart:typed_data';
 
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';

diff --git a/example/lib/place_fill.dart b/example/lib/place_fill.dart
@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import 'dart:async';
-import 'dart:typed_data';
 
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';

diff --git a/example/lib/place_source.dart b/example/lib/place_source.dart
@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import 'dart:async';
-import 'dart:typed_data';
 
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';

diff --git a/example/lib/place_symbol.dart b/example/lib/place_symbol.dart
@@ -5,7 +5,6 @@
 import 'dart:async'; // ignore: unnecessary_import
 import 'dart:core';
 import 'dart:math';
-import 'dart:typed_data';
 
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
@@ -113,7 +112,8 @@ class PlaceSymbolBodyState extends State<PlaceSymbolBody> {
     return iconImage == 'customFont'
         ? SymbolOptions(
             geometry: geometry,
-            iconImage: 'custom-marker', //'airport-15',
+            iconImage: 'custom-marker',
+            //'airport-15',
             fontNames: ['DIN Offc Pro Bold', 'Arial Unicode MS Regular'],
             textField: 'Airport',
             textSize: 12.5,

diff --git a/example/lib/util.dart b/example/lib/util.dart
@@ -1,5 +1,3 @@
-import 'dart:typed_data';
-
 import 'package:flutter/services.dart';
 import 'package:maplibre_gl/mapbox_gl.dart';