forked from cs3org/reva
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add the password policies (cs3org#4147)
* Add the password policies * defaultSpecialCharacters moved to the default config --------- Co-authored-by: Roman Perekhod <rperekhod@owncloud.com>
- Loading branch information
Showing
9 changed files
with
460 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # The test runner source for API tests | ||
| APITESTS_COMMITID=9c3511d2b08de25b16be3d309d0a7710b6848747 | ||
| APITESTS_COMMITID=5efc3c51a17e5c71a366436afeb52528ed49c7da | ||
| APITESTS_BRANCH=master | ||
| APITESTS_REPO_GIT_URL=https://github.com/owncloud/ocis.git |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Enhancement: Add the password policies | ||
|
|
||
| Add the password policies OCIS-3767 | ||
|
|
||
| https://github.com/cs3org/reva/pull/4147 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| package password | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "regexp" | ||
| "strings" | ||
| "unicode/utf8" | ||
| ) | ||
|
|
||
| // Validator describes the interface providing a password Validate method | ||
| type Validator interface { | ||
| Validate(str string) error | ||
| } | ||
|
|
||
| // Policies represents a password validation rules | ||
| type Policies struct { | ||
| minCharacters int | ||
| minLowerCaseCharacters int | ||
| minUpperCaseCharacters int | ||
| minDigits int | ||
| minSpecialCharacters int | ||
| specialCharacters string | ||
| digitsRegexp *regexp.Regexp | ||
| specialCharactersRegexp *regexp.Regexp | ||
| } | ||
|
|
||
| // NewPasswordPolicies returns a new NewPasswordPolicies instance | ||
| func NewPasswordPolicies(minCharacters, minLowerCaseCharacters, minUpperCaseCharacters, minDigits, minSpecialCharacters int, | ||
| specialCharacters string) (Validator, error) { | ||
| p := &Policies{ | ||
| minCharacters: minCharacters, | ||
| minLowerCaseCharacters: minLowerCaseCharacters, | ||
| minUpperCaseCharacters: minUpperCaseCharacters, | ||
| minDigits: minDigits, | ||
| minSpecialCharacters: minSpecialCharacters, | ||
| specialCharacters: specialCharacters, | ||
| } | ||
|
|
||
| p.digitsRegexp = regexp.MustCompile("[0-9]") | ||
| if len(specialCharacters) > 0 { | ||
| var err error | ||
| p.specialCharactersRegexp, err = regexp.Compile(specialCharactersExp(specialCharacters)) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } | ||
| return p, nil | ||
| } | ||
|
|
||
| // Validate implements a password validation regarding the policy | ||
| func (s Policies) Validate(str string) error { | ||
| var allErr error | ||
| if !utf8.ValidString(str) { | ||
| return fmt.Errorf("the password contains invalid characters") | ||
| } | ||
| err := s.validateCharacters(str) | ||
| if err != nil { | ||
| allErr = errors.Join(allErr, err) | ||
| } | ||
| err = s.validateLowerCase(str) | ||
| if err != nil { | ||
| allErr = errors.Join(allErr, err) | ||
| } | ||
| err = s.validateUpperCase(str) | ||
| if err != nil { | ||
| allErr = errors.Join(allErr, err) | ||
| } | ||
| err = s.validateDigits(str) | ||
| if err != nil { | ||
| allErr = errors.Join(allErr, err) | ||
| } | ||
| err = s.validateSpecialCharacters(str) | ||
| if err != nil { | ||
| allErr = errors.Join(allErr, err) | ||
| } | ||
| if allErr != nil { | ||
| return allErr | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (s Policies) validateCharacters(str string) error { | ||
| if s.count(str) < s.minCharacters { | ||
| return fmt.Errorf("at least %d characters are required", s.minCharacters) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (s Policies) validateLowerCase(str string) error { | ||
| if s.countLowerCaseCharacters(str) < s.minLowerCaseCharacters { | ||
| return fmt.Errorf("at least %d lowercase letters are required", s.minLowerCaseCharacters) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (s Policies) validateUpperCase(str string) error { | ||
| if s.countUpperCaseCharacters(str) < s.minUpperCaseCharacters { | ||
| return fmt.Errorf("at least %d uppercase letters are required", s.minUpperCaseCharacters) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (s Policies) validateDigits(str string) error { | ||
| if s.countDigits(str) < s.minDigits { | ||
| return fmt.Errorf("at least %d numbers are required", s.minDigits) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (s Policies) validateSpecialCharacters(str string) error { | ||
| if s.countSpecialCharacters(str) < s.minSpecialCharacters { | ||
| return fmt.Errorf("at least %d special characters are required. %s", s.minSpecialCharacters, s.specialCharacters) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (s Policies) count(str string) int { | ||
| return utf8.RuneCount([]byte(str)) | ||
| } | ||
|
|
||
| func (s Policies) countLowerCaseCharacters(str string) int { | ||
| var count int | ||
| for _, c := range str { | ||
| if strings.ToLower(string(c)) == string(c) && strings.ToUpper(string(c)) != string(c) { | ||
| count++ | ||
| } | ||
| } | ||
| return count | ||
| } | ||
|
|
||
| func (s Policies) countUpperCaseCharacters(str string) int { | ||
| var count int | ||
| for _, c := range str { | ||
| if strings.ToUpper(string(c)) == string(c) && strings.ToLower(string(c)) != string(c) { | ||
| count++ | ||
| } | ||
| } | ||
| return count | ||
| } | ||
|
|
||
| func (s Policies) countDigits(str string) int { | ||
| return len(s.digitsRegexp.FindAllStringIndex(str, -1)) | ||
| } | ||
|
|
||
| func (s Policies) countSpecialCharacters(str string) int { | ||
| if s.specialCharactersRegexp == nil { | ||
| return 0 | ||
| } | ||
| res := s.specialCharactersRegexp.FindAllStringIndex(str, -1) | ||
| return len(res) | ||
| } | ||
|
|
||
| func specialCharactersExp(str string) string { | ||
| // escape the '-' character because it is a not meta-characters but, they are special inside of [] | ||
| return "[" + strings.ReplaceAll(regexp.QuoteMeta(str), "-", `\-`) + "]" | ||
| } |
Oops, something went wrong.