Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-config-api): avoid loss of attributes in agama endpoints #2058

Merged
merged 3 commits into from
Aug 9, 2022
Merged

fix(jans-config-api): avoid loss of attributes in agama endpoints #2058

merged 3 commits into from
Aug 9, 2022

Conversation

jgomer2001
Copy link
Contributor

@jgomer2001 jgomer2001 commented Aug 9, 2022 •
edited by mo-auto
Loading

Resolves #1982
Closes #2059,

@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Aug 9, 2022
@mo-auto mo-auto mentioned this pull request Aug 9, 2022
Closed
@mo-auto
Copy link
Member

mo-auto commented Aug 9, 2022

Error: Hi @jgomer2001, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yuriyz yuriyz merged commit 3c8f816 into main Aug 9, 2022
@yuriyz yuriyz deleted the jans-config-api-issue_1982_1 branch August 9, 2022 11:51
pujavs pushed a commit that referenced this pull request Aug 9, 2022
@jgomer2001 @pujavs
fix(jans-config-api): avoid loss of attributes in agama endpoints (#2058
53a46f5 
)

* fix: avoid data loss #1982

* docs: remove PUT json endpoint #1982

* chore: remove unnecessary check #1982
ossdhaval pushed a commit that referenced this pull request Aug 16, 2022
@jgomer2001 @ossdhaval
fix(jans-config-api): avoid loss of attributes in agama endpoints (#2058
6be84ef 
)

* fix: avoid data loss #1982

* docs: remove PUT json endpoint #1982

* chore: remove unnecessary check #1982
@mo-auto mo-auto mentioned this pull request Aug 30, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Aug 30, 2022
Merged
@mo-auto mo-auto mentioned this pull request Nov 1, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@pujavs pujavs pujavs approved these changes

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
4 participants
@jgomer2001 @mo-auto @yuriyz @pujavs