Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-auth-server): archive rotated keys and make them available via endpoint #6437

Closed
3 tasks
yuriyz opened this issue Oct 31, 2023 · 0 comments · Fixed by #6503
Closed
3 tasks

feat(jans-auth-server): archive rotated keys and make them available via endpoint #6437

yuriyz opened this issue Oct 31, 2023 · 0 comments · Fixed by #6503
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request
Milestone
1.0.20

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Oct 31, 2023

Description

  1. When key is rotated, public part must be archived
  2. It should be possible to fetch it https://as.com/jwks/archived/{kid}
  3. Add configuration property for archived keys. Default value 1 year. After it's passed archived key is removed from DB.
  4. Swagger and docs must be updated.

Test cases and code coverage

  • Write unit test to cover added/changed code
  • Update integration tests to cover added/changed code
  • Swagger and docs
@yuriyz yuriyz added comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Oct 31, 2023
@yuriyz yuriyz added this to the 1.0.20 milestone Oct 31, 2023
@yuriyz yuriyz self-assigned this Oct 31, 2023
yuriyz added a commit that referenced this issue Nov 8, 2023
@yuriyz
feat(jans-auth-server): archive rotated keys and make them available …
91fe249 
…via endpoint #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
@yuriyz yuriyz mentioned this issue Nov 8, 2023
Merged
3 tasks
yuriyz added a commit that referenced this issue Nov 8, 2023
@yuriyz
feat(jans-auth-server): added /jwks/archived to swagger #6437
2474f85 
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
yuriyz added a commit that referenced this issue Nov 9, 2023
@yuriyz
feat(jans-auth-server): added jwk archive on key rotation #6437
b032193 
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
yuriyz added a commit that referenced this issue Nov 10, 2023
@yuriyz
feat(jans-auth-server): added tests for archived jwk and clean up sup…
bee643d 
…port #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
yuriyz added a commit that referenced this issue Nov 13, 2023
@yuriyz
feat(jans-auth-server): archived jwks (#6503)
c86ae0a 
* feat(jans-auth-server): archive rotated keys and make them available via endpoint #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* feat(jans-auth-server): added /jwks/archived to swagger #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* feat(jans-auth-server): added jwk archive on key rotation #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* feat(jans-auth-server): added tests for archived jwk and clean up support #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

---------

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
@yuriyz yuriyz mentioned this issue Dec 5, 2023
Closed
devrimyatar pushed a commit that referenced this issue Dec 30, 2023
@yuriyz @devrimyatar
feat(jans-auth-server): archived jwks (#6503)
6590691 
* feat(jans-auth-server): archive rotated keys and make them available via endpoint #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* feat(jans-auth-server): added /jwks/archived to swagger #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* feat(jans-auth-server): added jwk archive on key rotation #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* feat(jans-auth-server): added tests for archived jwk and clean up support #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

---------

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.0.20
Development

Successfully merging a pull request may close this issue.

feat(jans-auth-server): archived jwks JanssenProject/jans
1 participant
@yuriyz