Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-auth-server): archived jwks #6503

Merged
merged 4 commits into from Nov 13, 2023
Merged

feat(jans-auth-server): archived jwks #6503

merged 4 commits into from Nov 13, 2023

Conversation

yuriyz
Copy link
Contributor

@yuriyz yuriyz commented Nov 8, 2023 •
edited

Description

Archived jwks:

  1. When key is rotated, public part must be archived
  2. It is possible to fetch it https://as.com/jwks/archived/{kid}
  3. Added configuration property for exp of archived keys. Default value 1 year. After it's passed archived key is removed from DB.

Target issue

closes #6437

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@yuriyz
feat(jans-auth-server): archive rotated keys and make them available …
91fe249 
…via endpoint #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
@yuriyz yuriyz requested a review from yurem as a code owner November 8, 2023 13:03
@yuriyz yuriyz marked this pull request as draft November 8, 2023 13:03
@yuriyz yuriyz self-assigned this Nov 8, 2023
@yuriyz yuriyz added kind-feature Issue or PR is a new feature request comp-jans-auth-server Component affected by issue or PR labels Nov 8, 2023
@yuriyz yuriyz added this to the 1.0.21 milestone Nov 8, 2023
@mo-auto mo-auto added the comp-jans-linux-setup Component affected by issue or PR label Nov 8, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

[agama parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

[jans-pycloudlib] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

[Jans-Keycloak-Link] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

[Keycloak-Integration] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yuriyz
feat(jans-auth-server): added /jwks/archived to swagger #6437
2474f85 
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

[orm] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yuriyz
feat(jans-auth-server): added jwk archive on key rotation #6437
b032193 
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
@yuriyz
feat(jans-auth-server): added tests for archived jwk and clean up sup…
bee643d 
…port #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
@yuriyz yuriyz marked this pull request as ready for review November 10, 2023 09:28
@mo-auto mo-auto added the area-documentation Documentation needs to change as part of issue or PR label Nov 10, 2023
@yuriyz yuriyz merged commit c86ae0a into main Nov 13, 2023
2 checks passed
@yuriyz yuriyz deleted the jans-auth-server-6437 branch November 13, 2023 10:59
@mo-auto mo-auto mentioned this pull request Dec 11, 2023
Merged
@mo-auto3 mo-auto3 mentioned this pull request Dec 11, 2023
Merged
@mo-auto mo-auto mentioned this pull request Dec 11, 2023
Merged
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@yuriyz @devrimyatar
feat(jans-auth-server): archived jwks (#6503)
6590691 
* feat(jans-auth-server): archive rotated keys and make them available via endpoint #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* feat(jans-auth-server): added /jwks/archived to swagger #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* feat(jans-auth-server): added jwk archive on key rotation #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

* feat(jans-auth-server): added tests for archived jwk and clean up support #6437

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>

---------

Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurem yurem Awaiting requested review from yurem yurem is a code owner

@devrimyatar devrimyatar Awaiting requested review from devrimyatar devrimyatar is a code owner

Assignees

@yuriyz yuriyz

Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.0.21
Development

Successfully merging this pull request may close these issues.

feat(jans-auth-server): archive rotated keys and make them available via endpoint
2 participants
@yuriyz @mo-auto