Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(jans-auth-server): add oauth2-oidc-sdk dependency #6545

Closed
jgomer2001 opened this issue Nov 9, 2023 · 0 comments · Fixed by #6554
Closed

chore(jans-auth-server): add oauth2-oidc-sdk dependency #6545

jgomer2001 opened this issue Nov 9, 2023 · 0 comments · Fixed by #6554
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-dependencies Pull requests that update a dependency file
Milestone
1.0.21

Comments

@jgomer2001
Copy link
Contributor

Both agama inbound identity project and the Keycloack authn plugin depend on com.nimbus:oauth2-oidc-sdk (versions 10.13.2 and 10.11 respectively) to build their jar files. These are optional components that users can add to the AS

To allow the ease of deployment (ie. avoid copying jars to custom/libs , editing xml files, or building custom images in Cloud Native envs) we should include the nimbus dependency so that oauth2-oidc-sdk (and its transitives) are already bundled in the AS war.

I propose to use com.nimbus:oauth2-oidc-sdk:10.15 (the latest available in the 10.x series). Currently we only have nimbus-jose-jwt in the bom
@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR kind-dependencies Pull requests that update a dependency file labels Nov 9, 2023
@yuriyz yuriyz added this to the 1.0.21 milestone Nov 9, 2023
yuriyz added a commit that referenced this issue Nov 13, 2023
@yuriyz
chore(jans-auth-server): added oauth2-oidc-sdk dependency #6545
44b9b99 
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
@yuriyz yuriyz mentioned this issue Nov 13, 2023
Merged
yuriyz added a commit that referenced this issue Nov 14, 2023
@yuriyz
chore(jans-auth-server): added oauth2-oidc-sdk dependency #6545 (#6554)
247a66e 
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
devrimyatar pushed a commit that referenced this issue Dec 30, 2023
@yuriyz @devrimyatar
chore(jans-auth-server): added oauth2-oidc-sdk dependency #6545 (#6554)
a4d073a 
Signed-off-by: YuriyZ <yzabrovarniy@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
1.0.21
Development

Successfully merging a pull request may close this issue.

chore(jans-auth-server): added oauth2-oidc-sdk dependency #6545 JanssenProject/jans
3 participants
@yuriyz @jgomer2001 @mo-auto