-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config-api): Made client_id optional for TR / custom script #6617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…ientAttributes Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…tion Signed-off-by: pujavs <pujas.works@gmail.com>
…ns-config-api_issue
Signed-off-by: pujavs <pujas.works@gmail.com>
…ns-config-api_issue
Signed-off-by: pujavs <pujas.works@gmail.com>
…es for returning types Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
This was referenced Nov 23, 2023
[jans-linux-setup] Kudos, SonarCloud Quality Gate passed! |
[agama parent] Kudos, SonarCloud Quality Gate passed! |
[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed! |
yuriyz
approved these changes
Nov 23, 2023
nynymike
changed the title
fix(config-api): made clientId optional for TR and customScript changes for returning types
fix(config-api): Made client_id optional for TR / customScript
Nov 24, 2023
nynymike
changed the title
fix(config-api): Made client_id optional for TR / customScript
fix(config-api): Made client_id optional for TR / custom script
Nov 24, 2023
mo-auto
added
comp-jans-config-api
Component affected by issue or PR
kind-bug
Issue or PR is a bug in existing functionality
labels
Nov 24, 2023
devrimyatar
pushed a commit
that referenced
this pull request
Dec 30, 2023
…es for returning types (#6617) * fix(config-api): source LDAP server test * feat(config-api): pom changes for org json Signed-off-by: pujavs <pujas.works@gmail.com> * fix(config-api): sync with main Signed-off-by: pujavs <pujas.works@gmail.com> * docs(config-api): issue 6382 - regen spec to reflect new fields in ClientAttributes Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): json dependency changes Signed-off-by: pujavs <pujas.works@gmail.com> * fix(config-api): json build issue and saml plugin swagger spec annotation Signed-off-by: pujavs <pujas.works@gmail.com> * docs(config-api): auth featureFlags should be described as enum in spec Signed-off-by: pujavs <pujas.works@gmail.com> * docs(saml-plugin): saml swagger spec rectification #6604 Signed-off-by: pujavs <pujas.works@gmail.com> * fix(config-api): made clientId optional for TR and customScript changes for returning types Signed-off-by: pujavs <pujas.works@gmail.com> --------- Signed-off-by: pujavs <pujas.works@gmail.com> Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp-jans-config-api
Component affected by issue or PR
kind-bug
Issue or PR is a bug in existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
Description
Target issue
closes #6615 #6616
Implementation Details
clientId
optional for TR creationTest and Document the changes