Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-api): Made client_id optional for TR / custom script #6617

Merged
merged 14 commits into from
Nov 23, 2023

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Nov 23, 2023

Prepare


Description

Target issue

closes #6615 #6616

Implementation Details

  • 6615 : rectified code to return custom script types
  • 6616: made clientId optional for TR creation

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…ientAttributes

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…tion

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…es for returning types

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Copy link

sonarcloud bot commented Nov 23, 2023

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

sonarcloud bot commented Nov 23, 2023

[agama parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

sonarcloud bot commented Nov 23, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yuriyz yuriyz merged commit 9c59a06 into main Nov 23, 2023
5 of 6 checks passed
@yuriyz yuriyz deleted the jans-config-api_issue branch November 23, 2023 16:50
@nynymike nynymike changed the title fix(config-api): made clientId optional for TR and customScript changes for returning types fix(config-api): Made client_id optional for TR / customScript Nov 24, 2023
@nynymike nynymike changed the title fix(config-api): Made client_id optional for TR / customScript fix(config-api): Made client_id optional for TR / custom script Nov 24, 2023
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Nov 24, 2023
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
…es for returning types (#6617)

* fix(config-api): source LDAP server test

* feat(config-api): pom changes for org json

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): sync with main

Signed-off-by: pujavs <pujas.works@gmail.com>

* docs(config-api): issue 6382 - regen spec to reflect new fields in ClientAttributes

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): json dependency changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): json build issue and saml plugin swagger spec annotation

Signed-off-by: pujavs <pujas.works@gmail.com>

* docs(config-api): auth featureFlags should be described as enum in spec

Signed-off-by: pujavs <pujas.works@gmail.com>

* docs(saml-plugin): saml swagger spec rectification #6604

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): made clientId optional for TR and customScript changes for returning types

Signed-off-by: pujavs <pujas.works@gmail.com>

---------

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-tui): Post Auth and Spontaneous Scope script type are not appearing in Script Type list via Jans TUI
3 participants