Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kc-saml-plugin): code cleanup and improvement #6981

Closed
pujavs opened this issue Dec 7, 2023 · 0 comments · Fixed by #7054
Closed

feat(kc-saml-plugin): code cleanup and improvement #6981

pujavs opened this issue Dec 7, 2023 · 0 comments · Fixed by #7054
Assignees
@pujavs
Labels
comp-jans-config-api Component affected by issue or PR effort-3 Relative effort required for completion of issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality ready-for-triage Issue or PR has sufficient details and it is ready for triage review

Comments

@pujavs
Copy link
Contributor

pujavs commented Dec 7, 2023

  1. Add null checks
  2. Add mandatory check for file upload only for POST
  3. Remove mandatory check for file upload only for PUT
  4. Hide utility fields of DTO, not to be returned in response
@pujavs pujavs added kind-enhancement Issue or PR is an enhancement to an existing functionality comp-jans-config-api Component affected by issue or PR effort-3 Relative effort required for completion of issue or PR ready-for-triage Issue or PR has sufficient details and it is ready for triage review labels Dec 7, 2023
@pujavs pujavs self-assigned this Dec 7, 2023
@pujavs pujavs changed the title fix(kc-saml-plugin): code cleanup and improvement feat(kc-saml-plugin): code cleanup and improvement Dec 7, 2023
@mo-auto mo-auto added kind-bug Issue or PR is a bug in existing functionality kind-feature Issue or PR is a new feature request labels Dec 7, 2023
pujavs added a commit that referenced this issue Dec 7, 2023
@pujavs
feat(kc-saml-plugin): code cleanup and improvement #6981
d02bf2a 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs pujavs removed kind-bug Issue or PR is a bug in existing functionality kind-feature Issue or PR is a new feature request labels Dec 7, 2023
@pujavs pujavs mentioned this issue Dec 11, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pujavs pujavs

Labels
comp-jans-config-api Component affected by issue or PR effort-3 Relative effort required for completion of issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality ready-for-triage Issue or PR has sufficient details and it is ready for triage review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(kc-saml-plugin): cleanup and error handling JanssenProject/jans
2 participants
@pujavs @mo-auto