Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kc-saml-plugin): cleanup and error handling #7054

Merged
merged 7 commits into from
Dec 12, 2023
Merged

feat(kc-saml-plugin): cleanup and error handling #7054

merged 7 commits into from
Dec 12, 2023

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Dec 11, 2023

Prepare

Description

  • 6981: kc-saml-plugin - cleanup and error handling
  • 6944: Logging service giving error for saml-plugin on startup

Target issue

closes #6981 #6944

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs
fix(kc-saml-plugin): improvements as per issue#6981
63c517c 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
feat(config-api): sync with main
083cf75 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
c84d419 
…ns-kc-saml-plugin
@pujavs
feat(kc-saml-plugin): cleanup and error handling
408e01a 
Signed-off-by: pujavs <pujas.works@gmail.com>
@pujavs
feat(kc-saml-plugin): cleanup and error handling
6074888 
Signed-off-by: pujavs <pujas.works@gmail.com>
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Dec 11, 2023
yuriyz
yuriyz previously approved these changes Dec 11, 2023
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[agama parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[jans-pycloudlib] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[Jans-Keycloak-Link] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[orm] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[keycloak-integration-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pujavs
feat(kc-saml-plugin): sync with main
7280990 
Signed-off-by: pujavs <pujas.works@gmail.com>
moabu
moabu previously approved these changes Dec 12, 2023
View reviewed changes
@pujavs pujavs dismissed stale reviews from moabu and yuriyz via 7280990 December 12, 2023 06:52
@moabu moabu merged commit 7fcea4f into main Dec 12, 2023
1 of 2 checks passed
@moabu moabu deleted the jans-kc-saml-plugin branch December 12, 2023 06:53
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mo-auto mo-auto mentioned this pull request Dec 14, 2023
Merged
@pujavs pujavs mentioned this pull request Dec 18, 2023
Closed
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@pujavs @devrimyatar
feat(kc-saml-plugin): cleanup and error handling (#7054)
3b764f7 
* fix(kc-saml-plugin): improvements as per issue#6981

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): cleanup and error handling

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): cleanup and error handling

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(kc-saml-plugin): sync with main

Signed-off-by: pujavs <pujas.works@gmail.com>

---------

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz left review comments

@moabu moabu moabu left review comments

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(kc-saml-plugin): code cleanup and improvement
4 participants
@pujavs @yuriyz @moabu @mo-auto