Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(documentstore): should throw relevant exception rather than digest the exception #7919

Closed
pujavs opened this issue Mar 1, 2024 · 3 comments
Assignees
Labels
kind-feature Issue or PR is a new feature request

Comments

@pujavs
Copy link
Contributor

pujavs commented Mar 1, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@pujavs pujavs assigned yurem and moabu Mar 1, 2024
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Mar 1, 2024
@yurem
Copy link
Contributor

yurem commented Mar 1, 2024

According to @pujavs "...Right now methods return boolean making it difficult to calling client to understand the issue."

@yurem
Copy link
Contributor

yurem commented Mar 1, 2024

@shekhar16 LocalDocumentStore and DBDocumentStore should throw WriteDocumentException and DocumentException with parent exception. Both exceptions should extends RuntimeException. We don't need to add them to DocumentStore methods declarions

@shekhar16 shekhar16 self-assigned this Mar 7, 2024
moabu added a commit that referenced this issue Mar 12, 2024
#8030)

feat(documentstore): should throw relevant exception rather than digest the exception #7919

Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
@shekhar16
Copy link
Contributor

code has been merged closing this ticket. Please let me know if anything needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind-feature Issue or PR is a new feature request
Projects
None yet
Development

No branches or pull requests

5 participants