Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce endpoint to manage custom assets #2419

Closed
moabu opened this issue Sep 19, 2022 · 6 comments · Fixed by #8096
Closed

feat: introduce endpoint to manage custom assets #2419

moabu opened this issue Sep 19, 2022 · 6 comments · Fixed by #8096
Assignees
Labels
kind-feature Issue or PR is a new feature request
Milestone

Comments

@moabu
Copy link
Member

moabu commented Sep 19, 2022

Usecase

There should be a clear non filesystem (volume) based solution for possible user customization's such as login pages, CSS, libraries ..etc. Managed clearly by an API endpoint then further optimized by drag and drop in a parent admin ui.

Possible Solutions:

  1. Support different cloud buckets such as S3, Google bucket ...etc
  2. We use persistence and come up with a method to store the objects efficiently

My personal recommendation is to support this directly in our persistence and remove all file based requirements.

Implementation details:

@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Sep 19, 2022
@moabu moabu changed the title feat: use a central mechanisim for all possible user customized objects feat: use a central mechanisim for all possible user customized and shared module objects Sep 21, 2022
@jgomer2001
Copy link
Contributor

jgomer2001 commented Sep 22, 2022

Potentially related
GluuFederation/oxCore#223
GluuFederation/oxCore#188
#2506

@nynymike nynymike changed the title feat: use a central mechanisim for all possible user customized and shared module objects feat: introduce endpoint to manage custom assets Sep 23, 2022
@nynymike
Copy link
Contributor

What should we call this endpoint? /agama-assets ?

@jgomer2001
Copy link
Contributor

I'd say /jans-assets because it applies to several projects

@moabu moabu added this to the 1.0.3 milestone Sep 29, 2022
@moabu moabu modified the milestones: 1.0.3, 1.0.4 Nov 3, 2022
@moabu moabu modified the milestones: 1.0.4, 1.0.5 Nov 14, 2022
@moabu moabu modified the milestones: 1.0.5, 1.0.6 Dec 1, 2022
@moabu moabu modified the milestones: 1.0.6, 1.0.7 Jan 9, 2023
@moabu moabu modified the milestones: 1.0.7, 1.0.8, 1.0.9 Mar 1, 2023
@moabu moabu modified the milestones: 1.0.9, 1.0.10 Mar 9, 2023
@moabu moabu modified the milestones: 1.0.10, 1.0.11 Mar 16, 2023
@moabu moabu modified the milestones: 1.0.11, 1.0.12 Apr 5, 2023
@moabu moabu modified the milestones: 1.0.12, 1.0.13 Apr 18, 2023
@moabu moabu added this to the 1.0.16 milestone Jul 12, 2023
@moabu moabu modified the milestones: 1.0.16, 1.0.17 Aug 2, 2023
@moabu moabu modified the milestones: 1.0.17, 1.0.18 Sep 18, 2023
@moabu moabu modified the milestones: 1.0.18, 1.0.21 Nov 22, 2023
@moabu moabu modified the milestones: 1.0.21, 1.0.22 Dec 14, 2023
@moabu moabu modified the milestones: 1.0.22, 1.0.23 Feb 1, 2024
@moabu moabu assigned pujavs and unassigned jgomer2001 Feb 16, 2024
@pujavs
Copy link
Contributor

pujavs commented Feb 23, 2024

Requirement breakdown:

  1. Centrally managing assets(html,css,js,lib, etc) and leveraging existing DocumentStore for the same.
  2. Managing assets(html,css,js,lib, etc) in jetty classpath will require to use Jetty API.

@ossdhaval
Copy link
Contributor

@pujavs It looks like this change may require a documentation update as well. Please evaluate the documentation aspect and make the change along with the code change within this PR itself.

@pujavs
Copy link
Contributor

pujavs commented Mar 20, 2024

Implemented change via PR 8096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants