Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(documentstore): save document should return a handle to created asset or an identifier #7920

Closed
pujavs opened this issue Mar 1, 2024 · 3 comments
Closed

feat(documentstore): save document should return a handle to created asset or an identifier #7920

pujavs opened this issue Mar 1, 2024 · 3 comments
Assignees
@yurem @shekhar16 @moabu
Labels
kind-feature Issue or PR is a new feature request

Comments

@pujavs
Copy link
Contributor

pujavs commented Mar 1, 2024 •
edited
Loading

Right now the document store only returns a boolean true or false. Its should return a way to get to the created resource.
@pujavs pujavs assigned yurem and moabu Mar 1, 2024
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Mar 1, 2024
@pujavs pujavs changed the title feat(documentstore): should return a handle to created asset or an identifier feat(documentstore): save document should return a handle to created asset or an identifier Mar 1, 2024
@yurem
Copy link
Contributor

yurem commented Mar 1, 2024

@shekhar16 We can update DocumentStore saveXYZ.. API to return String instead of boolean. We don't need to backport this to Gluu CE.

LocalDocumentStoreProvider should return path to stored file instead of boolean
JcaDocumentStoreProvider should return normalizedPath of stored file instead of boolean
DbDocumentStoreProvider should return inumof stored file instead of boolean

@shekhar16 shekhar16 self-assigned this Mar 7, 2024
@yurem
Copy link
Contributor

yurem commented Mar 8, 2024

Updated API returns path specified in save/update/rename

@yurem
Copy link
Contributor

yurem commented Mar 8, 2024

implemented

yurem added a commit that referenced this issue Mar 8, 2024
@yurem
feat(documentstore): save document should return a handle to created …
da4e4ea 
…asset or an identifier #7920

Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
@yurem yurem closed this as completed Mar 8, 2024
@yurem yurem mentioned this issue Mar 8, 2024
Merged
yuriyz pushed a commit that referenced this issue Mar 8, 2024
@yurem
feat: doc store update (#8009)
59d4cd5 
* feat(documentstore): save document should return a handle to created asset or an identifier #7920

Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>

* feat: document store API should allow to specify file description #7981

Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>

* feat(documnt-store): should support document for all types required for jans asset mgt #7917

Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>

* feat(documnt-store): should support document for all types required for jans asset mgt #7917

Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>

* feat(documnt-store): should support document for all types required for jans asset mgt #7917

Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>

---------

Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurem yurem

@shekhar16 shekhar16

@moabu moabu

Labels
kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yurem @shekhar16 @pujavs @moabu @mo-auto