Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid LDAP schema reading token_server client ID #1321

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

iromli
Copy link
Contributor

@iromli iromli commented May 11, 2022

Description

While trying to upgrade data using ldap persistence, a LDAP schema error is thrown.

Here's the problematic line:

inum={token_server_admin_ui_client_id},ou=clients,o=jans

As token_server_admin_ui_client_id fetched from config layer may returns empty string (possibly admin-ui is not deployed), the empty inum value produces invalid DN.

This changeset checks whether the config is available before running data upgrade.

@iromli iromli requested a review from moabu as a code owner May 11, 2022 19:18
@mo-auto mo-auto added comp-docker-jans-persistence-loader kind-bug Issue or PR is a bug in existing functionality labels May 11, 2022
@moabu moabu merged commit db4f080 into main May 12, 2022
@moabu moabu deleted the cn-ldap-upgrade branch May 12, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-docker-jans-persistence-loader kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants