feat(jans-auth-server):get up tests updating arquillian and jetty-embedded issue 1247 #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-updating-arquillian-and-jetty
…s-updating-arquillian-and-jetty
mo-auto
added
comp-jans-auth-server
yuriyz
requested changes
Aug 4, 2022
| } | ||
|
|
||
| public ClientService getClientService() { | ||
| return (ClientService) HM_TEST_INJECTOR.get("ClientService"); |
There was a problem hiding this comment.
Can you check whether CdiUtil.bean(ClientService.class) will work instead of alien static holder? If it will work we have to drop this map.
There was a problem hiding this comment.
I have applied CdiUtil.bean, it is working thanks.
|
[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed! |
yuriyz
approved these changes
Aug 5, 2022
yuriyz
deleted the
feat-jans-auth-get-up-tests-updating-arquillian-and-jetty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
Description
Updating arquillian version, to allow running embedded jetty tests.
Target issue
#1247
closes #1247
Implementation Details
upgrade version arquillian-jetty-embedded-11 1.0.0.CR4
upgrade version arquillian test 1.7.0.Alpha10
allow using injection inside tests
Test and Document the changes